This repository was archived by the owner on Sep 9, 2026. It is now read-only.
Repository navigation
feat: logs added for es8 index - #1551
Merged
Merged
Conversation
Signed-off-by: agaraman0 <agaraman0@gmail.com>
Signed-off-by: agaraman0 <agaraman0@gmail.com>
Contributor
|
Hey @samsja I have tried to debug the failed test case but have not been able to figure it out as I have just added logs here. |
Member
|
these tests are failing because it needs to access a token in the docarray org but because you are opening a PR trough your fork you don't have access. Basically don't worry we will merge even if it fails |
Member
|
I will review asap btw |
samsja
reviewed
May 22, 2023
Signed-off-by: agaraman0 <agaraman0@gmail.com>
Signed-off-by: agaraman0 <agaraman0@gmail.com>
samsja
suggested changes
May 23, 2023
Signed-off-by: agaraman0 <agaraman0@gmail.com>
samsja
reviewed
May 23, 2023
Comment on lines
+132
to
+137
| self._logger.error( | ||
| 'A ElasticDocIndex must be typed with a Document type.' | ||
| 'To do so, use the syntax: ElasticDocIndex[DocumentType]' | ||
| ) | ||
|
|
||
| return self._db_config.index_name or default_index_name | ||
| raise ValueError | ||
| index_name = self._db_config.index_name or default_index_name |
Member
There was a problem hiding this comment.
You can do smth like
error_msg = 'A ElasticDocIndex must be typed with a Document type.'
'To do so, use the syntax: ElasticDocIndex[DocumentType]'
self._logger.error(error_msg)
raise ValueError(error_msg)
Signed-off-by: agaraman0 <agaraman0@gmail.com>
samsja
approved these changes
May 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding logs sequentially for all indexes in docarray according to issue