This repository was archived by the owner on Sep 9, 2026. It is now read-only.
Repository navigation
fix: use pd.concat() instead df.append() in to_dataframe() to avoid warning - #1478
Merged
Merged
Conversation
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
JoanFM
approved these changes
Apr 28, 2023
JoanFM
marked this pull request as ready for review
April 28, 2023 08:50
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
JoanFM
reviewed
Apr 28, 2023
| df_doc = pd.DataFrame(_dict_to_access_paths(doc.dict())) | ||
| df = pd.concat([df, df_doc], ignore_index=True) | ||
| doc_dict = _dict_to_access_paths(doc.dict()) | ||
| doc_dict = {k: [v] for k, v in doc_dict.items()} |
Member
There was a problem hiding this comment.
why do u need to convert them to list?
Contributor
Author
There was a problem hiding this comment.
pd.DataFrame.from_dict() expects a dict with the column names as keys, and the values have to be a list, therefore I wrap the value with a list
Contributor
Author
There was a problem hiding this comment.
like this v[0] would correspond to the first row, v[1] to the second row and so on. In our case we only have v[0] since len(v) = 1
|
📝 Docs are deployed on https://ft-fix-warning-in-to-dataframe--jina-docs.netlify.app 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid this warning, use
pd.concat():