Skip to content
This repository was archived by the owner on Sep 9, 2026. It is now read-only.

feat: point to older versions when importing Document or DocumentArray - #1422

Merged
anna-charlotte merged 3 commits into
mainfrom
feat-instruction-to-old-versions
Apr 19, 2023
Merged

anna-charlotte merged 3 commits into
mainfrom
feat-instruction-to-old-versions

Conversation

@anna-charlotte

@anna-charlotte anna-charlotte commented Apr 19, 2023 •

Copy link
Copy Markdown
Contributor

Point to older docarray versions from v1 if someone tries to run:

from docarray import Document, DocumentArray

Throw error with instructions to install older version:
image

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
@anna-charlotte
anna-charlotte requested a review from samsja April 19, 2023 07:54
@anna-charlotte
anna-charlotte marked this pull request as ready for review April 19, 2023 07:54
@samsja

samsja commented Apr 19, 2023

Copy link
Copy Markdown
Member

great !

Can u show pip install -U docarray==0.21.0 ?

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
Comment thread docarray/__init__.py Outdated

@samsja samsja left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last suggestion, I approved already so that you can merge

Co-authored-by: samsja <55492238+samsja@users.noreply.github.com>
Signed-off-by: Charlotte Gerhaher <charlotte.gerhaher@jina.ai>
@github-actions

Copy link
Copy Markdown

📝 Docs are deployed on https://ft-feat-instruction-to-old-versions--jina-docs.netlify.app 🎉

@anna-charlotte
anna-charlotte merged commit 53304ce into main Apr 19, 2023
@anna-charlotte
anna-charlotte deleted the feat-instruction-to-old-versions branch April 19, 2023 09:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants