Skip to content
This repository was archived by the owner on Sep 9, 2026. It is now read-only.
This repository was archived by the owner on Sep 9, 2026. It is now read-only.

[pydantic v2] csv and pandas reader DocList with Nested Documents is not working #1783

Closed

Description

@samsja

Context

Loading from csv and pandas with pydantic v2 is not working :

Activity

  1. converted this from a draft issue on Sep 15, 2023
  2. changed the title [-]csv reader DocList[/-] [+][pydantic v2] csv reader DocList[/+] on Sep 15, 2023
  3. changed the title [-][pydantic v2] csv reader DocList[/-] [+][pydantic v2] csv and pandas reader DocList is not working[/+] on Sep 15, 2023
  4. changed the title [-][pydantic v2] csv and pandas reader DocList is not working[/-] [+][pydantic v2] csv and pandas reader DocList with Nested Documents is not working[/+] on Sep 18, 2023
  5. linked a pull request that will close this issuetest: remove skip #1797on Sep 18, 2023
  6. JoanFM commented on Sep 18, 2023

    @JoanFM
    Member

    Actually, I feel that the this is caused by #1787.

    The tests that are failing are the ones where a precomputed csv assumes that an image can be constructed direcly from a url.

  7. JoanFM commented on Sep 18, 2023

    @JoanFM
    Member

    And the problem with pandas seems to be related to DocVec and not DocList

  8. JoanFM commented on Sep 18, 2023

    @JoanFM
    Member

    I think what is broken for the Pandas tests is the DocList to DocVec transformation with nested docuemnts

  9. moved this from Todo/Bug to In Progress in DocArray backlogon Sep 25, 2023
  10. self-assigned this
    on Sep 25, 2023
  11. linked a pull request that will close this issuefix: allow nested model dump via docvec #1808on Sep 28, 2023
  12. moved this from In Progress to Done in DocArray backlogon Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

Relationships

None yet

Development

No branches or pull requests

Issue actions