Skip to content
This repository was archived by the owner on Sep 9, 2026. It is now read-only.
This repository was archived by the owner on Sep 9, 2026. It is now read-only.

Add Field Description and example to Predefined Documents #1736

Closed

Description

@JoanFM

Initial Checks

  • I have searched Google & GitHub for similar requests and couldn't find anything
  • I have read and followed the docs and still think this feature is missing

Description

One nice thing about DocArray is the predefined Document types that we offer that allow people to use for multimodal applications.

Having rich field definitions, with description and examples would help when building services based on FastAPI with them.

Affected Components

Activity

  1. moved this to Todo/Features in DocArray backlogon Jul 31, 2023
  2. punndcoder28 commented on Aug 31, 2023

    @punndcoder28
    Contributor

    Hi, @JoanFM I can take this up and work on the changes. Could you provide more information on what is required for the change? Happy to work on it

  3. JoanFM commented on Aug 31, 2023

    @JoanFM
    MemberAuthor

    Hello @punndcoder28,

    Sure, what u need is to slowly add meaningful descriptions, use Field(description=...) to the fields of the predefined documents. You can split it in multiple PR

  4. punndcoder28 commented on Aug 31, 2023

    @punndcoder28
    Contributor

    Thanks for the quick reply. The predefined document types are those of TextDoc, and ImageDoc and the list of other docs as talked about here and field descriptions, for example on TextDoc, would be concise information for attributes text, url, embeddings and bytes?

  5. JoanFM commented on Aug 31, 2023

    @JoanFM
    MemberAuthor

    yes, you can add description and example field

  6. punndcoder28 commented on Aug 31, 2023

    @punndcoder28
    Contributor

    The description field would be for the document type and the example would be a separate section in the docs page?

  7. JoanFM commented on Aug 31, 2023

    @JoanFM
    MemberAuthor

    It is not about docs page sections, is about completing the fields of the predefined documents as it has been done for ID for the abstract BaseDoc

    id: Optional[ID] = Field(

  8. punndcoder28 commented on Aug 31, 2023

    @punndcoder28
    Contributor

    Thank you for the clarification

  9. moved this from Todo/Features to In progress by community in DocArray backlogon Sep 6, 2023
  10. punndcoder28 commented on Sep 20, 2023

    @punndcoder28
    Contributor

    @JoanFM I seem to have added field descriptions for all the predefined documents (which were present on docs). Are there any more I've missed?

  11. JoanFM commented on Sep 20, 2023

    @JoanFM
    MemberAuthor

    I do not think so, then let's close this ticket thanks

  12. moved this from In progress by community to Done in DocArray backlogon Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

good-first-issueSuitable as your first contribution to DocArray!

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions