Skip to content
This repository was archived by the owner on Sep 9, 2026. It is now read-only.
This repository was archived by the owner on Sep 9, 2026. It is now read-only.

tensor_type argument for all DocVec deserializations #1677

Closed

Description

@JohannesMessner

DocVec.from_protobuf(tensor_type=...) already exists, but this needs to be the case for all deserializations:

  • proto
  • json
  • pandas
  • bytes
  • binary
  • base64

Otherwise there is no way of knowing if the deserialized DocVec should use torch, np, or tf

Activity

  1. converted this from a draft issue on Jun 28, 2023
  2. JoanFM commented on Jun 28, 2023

    @JoanFM
    Member

    Can you elaborate more? does it need to be added, removed, commented?

  3. JohannesMessner commented on Jun 28, 2023

    @JohannesMessner
    MemberAuthor

    @JoanFM you need to slow down a bit, you're faster at commenting than I am at filling in the description of my own issue ;)

  4. JoanFM commented on Jun 28, 2023

    @JoanFM
    Member

    haha sorry, I just happened to be watching at that time

  5. moved this from In Progress to Done in DocArray backlogon Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions