This repository was archived by the owner on Sep 9, 2026. It is now read-only.
Repository navigation
This repository was archived by the owner on Sep 9, 2026. It is now read-only.
DocumentArray is not Generic for TypeVar #1146
Description
Context
DocumentArray is a Generic but cannot be used with TypeVar. We need to handle this case as well. We need to modify the class_getitem of AnyDocumentArray.
This don't work
from docarray import DocumentArray, BaseDocument
from typing import TypeVar, List
T = TypeVar('T', bound=BaseDocument)
def f(a: DocumentArray[T]) -> DocumentArray[T]:
return aTraceback (most recent call last):
File "scratch_3.py", line 7, in <module>
def f(a: DocumentArray[T]) -> DocumentArray[T]:
File "docarray/docarray/array/abstract_array.py", line 38, in __class_getitem__
if not issubclass(item, BaseDocument):
File "/versions/3.9.10/lib/python3.9/abc.py", line 123, in __subclasscheck__
return _abc_subclasscheck(cls, subclass)
TypeError: issubclass() arg 1 must be a classwhereas this work fine
def g(a: List[T]) -> List[T]:
return a
Activity
agaraman0 commentedon Feb 23, 2023
Hey, @samsja I would like to pick up this issue.
samsja commentedon Feb 23, 2023
Hey @agaraman0 unfortunately the PR to fix this bug has already been merged: #1147
I will close this issue