Skip to content

Master issue295 tsig fix #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
frankarinnet wants to merge 5 commits into from
+205 −42
Closed

Master issue295 tsig fix #296

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b92bcd8
Issue 295, addresses bug with TSIG verification of large responses.
frankarinnet Oct 23, 2023
2def163
Neatened formatting.
frankarinnet Oct 23, 2023
9797928
Test for Issue 295 added as well as a related change to give more con…
nguichon Oct 25, 2023
3997863
Merge branch 'master_issue_295_test' into master_issue295_tsig_fix
nguichon Oct 25, 2023
87ae7ac
Edited docs for modified TSIG generate method
nguichon Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Neatened formatting.
  • Loading branch information
@frankarinnet
frankarinnet committed Oct 23, 2023
commit 2def163288959c51760b1fba4a3020694d3389d9
4 changes: 2 additions & 2 deletions src/main/java/org/xbill/DNS/TSIG.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,7 +592,7 @@ public int verify(Message m, byte[] messageBytes, TSIGRecord requestTSIG, boolea
m.tsigState = Message.TSIG_FAILED;
TSIGRecord tsig = m.getTSIG();

if( fullSignature ) {
if (fullSignature) {
if (!tsig.getName().equals(name) || !tsig.getAlgorithm().equals(alg)) {
log.debug(
"BADKEY failure on message id {}, expected: {}/{}, actual: {}/{}",
Expand Down Expand Up @@ -643,7 +643,7 @@ public int verify(Message m, byte[] messageBytes, TSIGRecord requestTSIG, boolea

// TODO: style question whether to prefer "return early" or to have a single return at the end.
// return early for the intermediate messages between tsigs
if( tsig == null ) {
if (tsig == null) {
m.tsigState = Message.TSIG_INTERMEDIATE;
return Rcode.NOERROR;
}
Expand Down