Change semantics of DNSInput.saveActive()#228
Merged
Conversation
Previously, DNSInput.saveActive() would return the active range without taking prior calls to setActive() into account. Add a test case that illustrates the failure that the user experienced, as well as a test case verifying DNSInput semantics when called recursively with ByteBuffers with limit and length set. Please see dnsjava#225 for further details.
Member
Author
|
This is a cherry-picked version of #227 for the release/3.4.x branch |
Codecov Report
@@ Coverage Diff @@
## release/3.4.x #228 +/- ##
===================================================
- Coverage 56.14% 56.00% -0.14%
+ Complexity 2027 2021 -6
===================================================
Files 163 163
Lines 10843 10843
Branches 1566 1566
===================================================
- Hits 6088 6073 -15
- Misses 4336 4351 +15
Partials 419 419
Continue to review full report at Codecov.
|
ibauersachs
approved these changes
Oct 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, DNSInput.saveActive() would return the active range without
taking prior calls to setActive() into account.
Add a test case that illustrates the failure that the user experienced,
as well as a test case verifying DNSInput semantics when called
recursively with ByteBuffers with limit and length set.
Please see #225 for further
details.