Use map container properties for process elements#637
Conversation
…and connection editor improvments
|
@marvinoe21 I am not sure when to merge this code but a review would be good to be ready to add it to be prepared for the first version in combination with GTlab 2.1 |
rainman110
left a comment
There was a problem hiding this comment.
Great work and it seems to be correct in the most cases.
Please make the upgrade routine more defensive (they would do the wrong things, if the xml is not as expected) and cleanup the code according to my comments.
|
@rainman110 Thanks for the review. I worked on it and hope now the code is improved. Please check again if everything is fine now |
rainman110
left a comment
There was a problem hiding this comment.
Hi @jensschmeink . Thanks for fixing it up.
I have only a few smaller change requests from your fixup and some general remark for the next time then.
| */ | ||
|
|
||
| /** | ||
| * @brief getPropertyContainerVal |
There was a problem hiding this comment.
Maybe rephrase a bit like
@brief Returns the member value of a struct inside a property container
There was a problem hiding this comment.
Also, please move the text "In contrast to function above this function does not use the index"
after the @brief section leaving an empty line between brief and the additional text, not in between the parameters.
|
@rainman110 added more changes |
rainman110
left a comment
There was a problem hiding this comment.
@jensschmeink There was on thing missing from the last code review.
Please rephrase the docstring as suggested and move the explanation (difference to the other function) up after the brief section
| */ | ||
|
|
||
| /** | ||
| * @brief getPropertyContainerVal |
The new development of container properties for GTlab which now can be handled via names instead of indices are beneficial for usage in python process elements.
As this changes the datamodel an module upgrader is needed aswell to convert old projects to the new structure