Use devtools cmake package#633
Conversation
|
Nice! But there is one thing I noticed: I tested it with our internal DevTools and it works as expected. However, it does not work when using the community DevTools. Perhaps we should provide the new cmake config package in the community DevTools before merging these changes into master. What do you think? |
|
@marvinoe21 I think, the community installer will only be updated after we tag the deployment tester. We did not do this yet, right? I have definitely tested it with the community branch installer. Also, the cmake files are part of the community repo. The core repo just adds some internal configs. |
|
@rainman110 Yes, that’s the problem. I think we should tag the deployment tester before merging this. |
|
sounds good |
|
@marvinoe21 Since the devtools now contain the cmake scripts, we could merge this, right? |
It also removes the local gtlab.cmake as it is not required anymore.