Skip to content

Use devtools cmake package#633

Merged
marvinoe21 merged 3 commits into
masterfrom
use_devtools_package
Mar 3, 2026
Merged

Use devtools cmake package#633
marvinoe21 merged 3 commits into
masterfrom
use_devtools_package

Conversation

@rainman110
Copy link
Copy Markdown
Contributor

It also removes the local gtlab.cmake as it is not required anymore.

@marvinoe21
Copy link
Copy Markdown
Collaborator

Nice! But there is one thing I noticed: I tested it with our internal DevTools and it works as expected. However, it does not work when using the community DevTools. Perhaps we should provide the new cmake config package in the community DevTools before merging these changes into master. What do you think?

@rainman110
Copy link
Copy Markdown
Contributor Author

rainman110 commented Nov 13, 2025

@marvinoe21 I think, the community installer will only be updated after we tag the deployment tester. We did not do this yet, right?

I have definitely tested it with the community branch installer. Also, the cmake files are part of the community repo. The core repo just adds some internal configs.

@marvinoe21
Copy link
Copy Markdown
Collaborator

@rainman110 Yes, that’s the problem. I think we should tag the deployment tester before merging this.

@rainman110
Copy link
Copy Markdown
Contributor Author

sounds good

@rainman110
Copy link
Copy Markdown
Contributor Author

@marvinoe21 Since the devtools now contain the cmake scripts, we could merge this, right?

@marvinoe21 marvinoe21 merged commit 7b06b7f into master Mar 3, 2026
1 check passed
@marvinoe21 marvinoe21 deleted the use_devtools_package branch March 3, 2026 13:18
@marvinoe21 marvinoe21 added this to the 1.8.1 milestone Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants