Skip to content

compatible with Python 3.12#50

Open
piranna wants to merge 12 commits intodjango-macaddress:mainfrom
TRC-Informatica:main
Open

compatible with Python 3.12#50
piranna wants to merge 12 commits intodjango-macaddress:mainfrom
TRC-Informatica:main

Conversation

@piranna
Copy link
Copy Markdown

@piranna piranna commented Sep 19, 2024

Fix #49

Comment thread macaddress/__init__.py
@piranna
Copy link
Copy Markdown
Author

piranna commented Nov 14, 2024

Any update on this? Can we get it merged?

@piranna
Copy link
Copy Markdown
Author

piranna commented Nov 14, 2024

I've fixed #51 here too, by upgrading to use pyproject.toml file.

kra3
kra3 previously approved these changes Nov 17, 2024
@kra3
Copy link
Copy Markdown
Member

kra3 commented Nov 17, 2024

@piranna thanks a lot for addressing the concerns and upgrading the build tooling to poetry.

I have also realised travis integration is broken, so I've replaced travis with GitHub workflows (#45).
Could you please kind enough to rebase the PR branch to main branch. Once the build pass, I will cut a release.

@piranna
Copy link
Copy Markdown
Author

piranna commented Nov 18, 2024

thanks a lot for addressing the concerns and upgrading the build tooling to poetry.

You are welcome.

Could you please kind enough to rebase the PR branch to main branch.

Done, can you review it?

@kra3
Copy link
Copy Markdown
Member

kra3 commented Nov 21, 2024

unfortunately, tests are failing here (needs to update workflows to use poetry).
However test are failing for me locally poetry run pytest.
Ware you able to run tests successfully in your local machine ? how are you running tests ?

@Djailla
Copy link
Copy Markdown
Contributor

Djailla commented Oct 2, 2025

Duplicated from last release, can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not compatible with Python 3.12

3 participants