Fixed #36487 -- Fixed logger error message with partial callbacks.#19609
Conversation
There was a problem hiding this comment.
Hello! Thank you for your contribution 💪
As it's your first contribution be sure to check out the patch review checklist.
If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!
If you have any design or process questions then you can ask in the Django forum.
Welcome aboard ⛵️!
|
Hello @krishna-holvi, the problem seems legitimate but just like any non-trivial bug fixing this will require a ticket as well as tests. See 4a1150b to get an idea for where the tests should be added. It might also be an opportunity to change the |
Many thanks for having a look and thank you for those links. I'll update the PR |
3426f37 to
a8db985
Compare
|
Looks like it caused a few failures See
Try running this particular suite locally |
b087dca to
1839277
Compare
|
Updated with simplified approach as discussed in ticket. thank you! |
2f6bc74 to
7c6b037
Compare
|
@charettes tests are passing now, can you please have a look |
de893bf to
54c777f
Compare
jacobtylerwalls
left a comment
There was a problem hiding this comment.
Looks really good. Can I ask you to give one last thought to a possible third test, and let me know whether it's feasible. Thanks.
54c777f to
6da82ac
Compare
6da82ac to
8c0d5c8
Compare
📊 Coverage Report for Changed FilesNote: Missing lines are warnings only. Some lines may not be covered by SQLite tests as they are database-specific. For more information about code coverage on pull requests, see the contributing documentation. |
@jacobtylerwalls Thanks for the thorough review! I think I've addressed both suggestions, please let me know if there's anything else that needs adjustment. |
Trac ticket number
ticket-36487
Branch description
This is a trivial change to fix the logger error message. Fixed the error message for the case on commit callback is a partial which doesn't have the property
__qualname__.Checklist
mainbranch.