refactor: replace dependency with initial implementation#6310
Merged
iCrawl merged 1 commit intodiscordjs:masterfrom Aug 6, 2021
VoltrexKeyva:master
Merged
refactor: replace dependency with initial implementation#6310iCrawl merged 1 commit intodiscordjs:masterfrom VoltrexKeyva:master
iCrawl merged 1 commit intodiscordjs:masterfrom
VoltrexKeyva:master
Conversation
Removed the `abortcontroller` from dependencies as a favor of the initial `AbortController` API implementation. Refs: [Graduation of the initial AbortController implementation](nodejs/node#35949)
kyranet
approved these changes
Aug 6, 2021
iCrawl
approved these changes
Aug 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR removes the abort-controller package from the dependencies as a favor of the initial Node.js implementation of the AbortController API which was graduated here.
The lib should use the initial implementation of the APIs if possible.
Status and versioning classification: