xiiui ← Fix bookmark icon and color not showing in header#27034
Merged
formfcw merged 124 commits intofeat/twelve-uifrom Apr 9, 2026
Merged
xiiui ← Fix bookmark icon and color not showing in header#27034formfcw merged 124 commits intofeat/twelve-uifrom
formfcw merged 124 commits intofeat/twelve-uifrom
Conversation
Review note: Rebuild `pnpm --filter themes build`
… components Review note: Rebuild `pnpm --filter composables --filter themes --filter types build` Docs note: sidebarShadow and headerShadow prop removed from defineLayout()
…ll type scales Review note: Rebuild `pnpm --filter themes --filter types build`
- v-text-overflow.vue (line-height: normal) - v-card-title.vue (font-weight, line-height) - form-field-label.vue (scoped .type-label, magic numbers → --label-height)
- form-field.vue (link underline) - user-popover.vue (status chip margin)
…n theme types Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…in theme defs Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…cus ring Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… ring Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…e--primary Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Review note: Test e.g. in data model settings > <collection> > display template
…' into florian/cms-2040-update-focus-ring
…' into florian/cms-2040-update-focus-ring
Review note: In the new design there won’t be a default border for this element, that’s why I’ve already removed it here.
HZooly
requested changes
Apr 3, 2026
Member
HZooly
left a comment
There was a problem hiding this comment.
Two minor things about the fallbacks not working as expected
Co-authored-by: Hugo Torzuoli <torzuoli.hugo@gmail.com>
HZooly
approved these changes
Apr 7, 2026
Base automatically changed from
florian/cms-1923-add-header-button-component
to
feat/twelve-ui
April 9, 2026 09:08
…-color-not-showing-in-header
formfcw
added a commit
that referenced
this pull request
Apr 9, 2026
Co-authored-by: HZooly <torzuoli.hugo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
What's changed:
iconandcolortolocalPresetinuse-preset.tsso the header bar can read themuseCollectionHeader()incollection.vueto derive header title, icon, and color — now bookmark-aware instead of always fallingthrough to collection defaults
smallprop from context toggle button innavigation-bookmarkto match the chevron icon sizingPotential Risks / Drawbacks
—
Tested Scenarios
Review Notes / Questions
use-preset.ts:108-109—iconandcolorwere simply never copied tolocalPresetsmallremoval on the context toggle is a design alignment tweak, not part of the bug fixChecklist
Addresses CMS-2079