Skip to content

Fix Cosmetic "Dataset Explorer, after scrolling down a certain amount error"#1585

Merged
anthony-chaudhary merged 1 commit intomasterfrom
fix-selection-warning
Feb 14, 2024
Merged

Fix Cosmetic "Dataset Explorer, after scrolling down a certain amount error"#1585
anthony-chaudhary merged 1 commit intomasterfrom
fix-selection-warning

Conversation

@anthony-chaudhary
Copy link
Copy Markdown
Member

Fixes
#1571

  • This was a "Cosmetic" only item, since the '0' object was not a valid file there was nothing to unselect.
  • The root of it injecting the '0' can be solved as part of refactoring the file push and concat block which should be seperate functions.

Additional Context

  • Error: Cannot create property 'selected' on string '0'
  • In theory a file object should never be a string '0', however, it seems to be adding this in, so until that root item is solved adding this check to filter out the '0's (which aren't valid file objects)
  • In limited testing it only seems to happen once, so some process is adding it in a funny way
    For example:
    file list has a zero

Context of error:
Cannot create property 'selected' on string '0'
In theory a file object should never be a string '0', however, it seems to be adding this in, so until that root item is solved adding this check to filter out the '0's (which aren't valid file objects)

In limited testing it only seems to happen once, so some process is adding it in a funny way
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 14, 2024

Unit Test Results

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit b9c94eb. ± Comparison against base commit e2fb3ab.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant