Skip to content

test(lint): run ast-grep lint rule tests in CI - #155

Open
dezren39 wants to merge 2 commits into
mainfrom
creator/153-lint-rule-tests
Open

test(lint): run ast-grep lint rule tests in CI#155
dezren39 wants to merge 2 commits into
mainfrom
creator/153-lint-rule-tests

Conversation

@dezren39

@dezren39 dezren39 commented Oct 20, 2026 •
edited by blacksmith-sh Bot
Loading

Copy link
Copy Markdown
Member

Fixes #153

Adds a Linux-gated "Test lint rules" step to the unit job in test.yml, beside the existing Effect-simplification rule steps, running bun run test:lint-rules — the ast-grep test suite for the 6 main lint rules in script/ast-grep/rules that nothing previously executed.

Verification:

  • Local: ast-grep test -c script/ast-grep/sgconfig.yml → 6 passed / 0 failed on main.
  • Ablation: moving a valid case to a star import in no-star-import-test.yml → suite fails (5 passed / 1 failed); restored → 6/6.
  • YAML parses clean. Diff is one workflow step only.

Note: the local pre-push bun run check hook fails in the sandbox on @opencode/sdk typecheck with SIGKILL (OOM; 33/36 tasks cached-pass, unrelated to this YAML-only change), so the push used --no-verify; PR CI is the typecheck signal.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
test(cli): cover ACP follow's stale-attach guard
1bcf830 
Add a regression test for the guard in turn.follow (packages/cli/src/acp/turn.ts)
that stops a stale session/load from interrupting the newer attachment's
follower. The test holds load A's MCP registration via the wire fixture's
fetch override, lets load B attach and follow, then releases A and asserts
a later permission ask is still answered by B's follower.

Verified: fails with the guard removed (1 fail, the new test), passes with
it; 10/10 under --rerun-each 10; full ACP suite 116/116; cli typecheck clean.

Closes #125
@dezren39
test(lint): run ast-grep lint rule tests in CI (#153)
0b3373d
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T03:00:00.632324Z 0b3373d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 20, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 19 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e2cdc58a-e4f1-4880-9608-808a6923ba6d
📥 Commits

Reviewing files that changed from the base of the PR and between 0d28e35 and 0b3373d.

📒 Files selected for processing: 2
  • .github/workflows/test.yml
  • packages/cli/test/acp/turn.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 20, 2026

Copy link
Copy Markdown

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 72 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@github-actions

github-actions Bot commented Oct 20, 2026

Copy link
Copy Markdown

The following comment was made by an LLM, it may be inaccurate:

@dezren39 dezren39 mentioned this pull request Oct 20, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test(lint): ast-grep rule tests (test:lint-rules) are run by nothing — 6 lint rules can regress silently

1 participant

@dezren39