Skip to content

🎨 Palette: Add ARIA labels to icon buttons - #253

Draft
dezren39 wants to merge 2 commits into
mainfrom
palette/accessibility-aria-labels-1388266613375029113
Draft

dezren39 wants to merge 2 commits into
mainfrom
palette/accessibility-aria-labels-1388266613375029113

Conversation

@dezren39

Copy link
Copy Markdown
Member

💡 What: Added aria-label attributes to empty icon buttons in the Rust templates (theme selectors and inline tag add button).
🎯 Why: These buttons previously lacked readable text for screen readers, meaning visually impaired users would not understand their purpose. Adding aria-label ensures the interface is more accessible.
♿ Accessibility: Significant improvement for screen reader navigation in the core UI layout.
📸 Before/After: No visual change; strictly a semantic HTML/accessibility fix.


PR created automatically by Jules for task 1388266613375029113 started by @dezren39

Added `aria-label` attributes to the empty `theme-btn` elements and the inline tag add `+` button in `pkgs/id/src/web/templates.rs`. This ensures these icon-only buttons are properly accessible to screen readers, providing clear context about their function.

Also recorded this learning in `.Jules/palette.md` for future reference.

Co-authored-by: dezren39 <11225574+dezren39@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Oct 18, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Added `aria-label` attributes to the empty `theme-btn` elements and the inline tag add `+` button in `pkgs/id/src/web/templates.rs`. This ensures these icon-only buttons are properly accessible to screen readers, providing clear context about their function.

Also recorded this learning in `.Jules/palette.md` for future reference.

Co-authored-by: dezren39 <11225574+dezren39@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant