Repository navigation
Conversation
…ighlights Replaced an O(N) regex findNext loop with an O(1) lookup of pre-computed decorations from the prosemirror-search plugin state to drastically reduce blocking work on the main thread for documents with many matches. Co-authored-by: dezren39 <11225574+dezren39@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
…ighlights Replaced an O(N) regex findNext loop with an O(1) lookup of pre-computed decorations from the prosemirror-search plugin state to drastically reduce blocking work on the main thread for documents with many matches. Co-authored-by: dezren39 <11225574+dezren39@users.noreply.github.com>
…ighlights Replaced an O(N) regex findNext loop with an O(1) lookup of pre-computed decorations from the prosemirror-search plugin state to drastically reduce blocking work on the main thread for documents with many matches. Co-authored-by: dezren39 <11225574+dezren39@users.noreply.github.com>
…ighlights Replaced an O(N) regex findNext loop with an O(1) lookup of pre-computed decorations from the prosemirror-search plugin state to drastically reduce blocking work on the main thread for documents with many matches. Co-authored-by: dezren39 <11225574+dezren39@users.noreply.github.com>
…ighlights Replaced an O(N) regex findNext loop with an O(1) lookup of pre-computed decorations from the prosemirror-search plugin state to drastically reduce blocking work on the main thread for documents with many matches. Co-authored-by: dezren39 <11225574+dezren39@users.noreply.github.com>
💡 What: Replaced a manual O(N) regex loop (
findNext) with an O(1) lookup of pre-computed match decorations fromprosemirror-search's state usinggetMatchHighlights().🎯 Why: Searching a large document with a common query like a space
" "caused severe main thread blocking ascountMatches()iterated over every single match in the document manually, despite theprosemirror-searchplugin having already done the work.📊 Impact: Match counting is now instantaneous regardless of the number of matches, eliminating a performance bottleneck on keystroke updates in the search panel.
🔬 Measurement: Search for a single space in a large document and note the UI no longer freezes during keystrokes in the find field.
PR created automatically by Jules for task 14772891927514724369 started by @dezren39