Repository navigation
Conversation
- Removed global `decorationGeneration` hack that forced DOM recreation. - Refactored `Decoration.widget` to use factory functions instead of passing pre-instantiated DOM nodes. - Implemented stable keys dynamically derived from visual state (e.g., opacity, color, connection state) to ensure nodes are only recreated when their appearance fundamentally changes. Co-authored-by: dezren39 <11225574+dezren39@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
- Removed global `decorationGeneration` hack that forced DOM recreation. - Refactored `Decoration.widget` to use factory functions instead of passing pre-instantiated DOM nodes. - Implemented stable keys dynamically derived from visual state (e.g., opacity, color, connection state) to ensure nodes are only recreated when their appearance fundamentally changes. Co-authored-by: dezren39 <11225574+dezren39@users.noreply.github.com>
💡 What: Removed the global
decorationGenerationmechanism from the collaborative cursors rendering and implemented the factory pattern with stable dynamic keys for ProseMirror'sDecoration.widget.🎯 Why: Previously, appending a generation counter to every cursor decoration's key forced ProseMirror to destroy and recreate the DOM node on every single transaction (e.g., typing a character). This caused excessive layout thrashing and garbage collection, severely degrading performance when multiple remote cursors were present.
📊 Impact: This drastically reduces unnecessary DOM allocations and garbage collection pressure by properly reusing existing DOM nodes for inactive or moving cursors whose visual state hasn't fundamentally changed.
🔬 Measurement: The improvement can be verified by observing significantly reduced GC activity in Chrome DevTools during active typing with multiple collaborative cursors connected. Tests have been successfully verified with
bun run typecheckandbun run test.PR created automatically by Jules for task 1720452713847757073 started by @dezren39