Repository navigation
Conversation
💡 What: Changed ProseMirror `Decoration.widget` construction in collaborative cursor plugin to use DOM factory functions (`() => HTMLElement`) and stable recycling keys based on dynamic properties (`opacity`, `connectionState`, `color`). Eliminated `decorationGeneration` logic which bypassed recycling. 🎯 Why: Instantiating DOM nodes directly during decoration mapping without recycling causes severe layout thrashing and continuous garbage collection when cursors move. 📊 Impact: Expected to dramatically reduce memory pressure and layout recalculation pauses when typing in collaboratively edited documents. 🔬 Measurement: Verify cursor updates now simply move existing DOM nodes rather than continuously creating/destroying nodes in browser DevTools. Co-authored-by: dezren39 <11225574+dezren39@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
💡 What: Fixed two biome lint warnings for an unused/unassigned `leftmostCursorLine` variable in `pkgs/id/web/src/cursors.ts` that were uncovered during CI. 🎯 Why: The CI `nix flake check` failed due to the `id-biome-check` job failing on formatting and unused variables which were introduced when refactoring DOM node generation to utilize factory functions in the previous commit. 📊 Impact: Expected to pass CI formatting and linting checks. 🔬 Measurement: Verify `bunx @biomejs/biome check src/cursors.ts` reports no errors or warnings locally. Co-authored-by: dezren39 <11225574+dezren39@users.noreply.github.com>
💡 What: Fixed two biome lint warnings for an unused/unassigned `leftmostCursorLine` variable in `pkgs/id/web/src/cursors.ts` that were uncovered during CI. 🎯 Why: The CI `nix flake check` failed due to the `id-biome-check` job failing on formatting and unused variables which were introduced when refactoring DOM node generation to utilize factory functions in the previous commit. 📊 Impact: Expected to pass CI formatting and linting checks. 🔬 Measurement: Verify `bunx @biomejs/biome check src/cursors.ts` reports no errors or warnings locally. Co-authored-by: dezren39 <11225574+dezren39@users.noreply.github.com>
💡 What: Fixed formatting in `.jules/bolt.md` using prettier. 🎯 Why: CI `treefmt check` job failed due to formatting issues in the markdown file generated during previous code changes. 📊 Impact: Expected to pass CI formatting checks. 🔬 Measurement: Verify tests run cleanly on CI. Co-authored-by: dezren39 <11225574+dezren39@users.noreply.github.com>
💡 What: Fixed rust code formatting in `pkgs/id/src/blob_gate.rs` using `cargo fmt`. 🎯 Why: CI `cargo-fmt-check` failed. Even though this isn't in a file touched by this agent run, fixing it resolves the overall CI check suite failure. 📊 Impact: Expected to pass CI formatting checks. 🔬 Measurement: Verify `cargo fmt --check` succeeds. Co-authored-by: dezren39 <11225574+dezren39@users.noreply.github.com>
💡 What: Fixed rust code formatting in `pkgs/id/src/blob_gate.rs` using `cargo fmt`. 🎯 Why: CI `cargo-fmt-check` failed. Even though this isn't in a file touched by this agent run, fixing it resolves the overall CI check suite failure. 📊 Impact: Expected to pass CI formatting checks. 🔬 Measurement: Verify `cargo fmt --check` succeeds. Co-authored-by: dezren39 <11225574+dezren39@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 What: Changed ProseMirror
Decoration.widgetconstruction in collaborative cursor plugin to use DOM factory functions (() => HTMLElement) and stable recycling keys based on dynamic properties (opacity,connectionState,color). EliminateddecorationGenerationlogic which bypassed recycling.🎯 Why: Instantiating DOM nodes directly during decoration mapping without recycling causes severe layout thrashing and continuous garbage collection when cursors move.
📊 Impact: Expected to dramatically reduce memory pressure and layout recalculation pauses when typing in collaboratively edited documents.
🔬 Measurement: Verify cursor updates now simply move existing DOM nodes rather than continuously creating/destroying nodes in browser DevTools.
PR created automatically by Jules for task 10118274821565687820 started by @dezren39