Repository navigation
Conversation
…ashing Replaces the global `decorationGeneration` counter (which forced DOM node recreation on every editor state change) with stable keys based on actual cursor data (client ID, position, opacity, and connection state). This allows ProseMirror to recycle DOM elements effectively. Also wrapped `Decoration.widget` components in a factory function to conform with ProseMirror's recycling APIs. Co-authored-by: dezren39 <11225574+dezren39@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
…ashing Replaces the global `decorationGeneration` counter (which forced DOM node recreation on every editor state change) with stable keys based on actual cursor data (client ID, position, opacity, and connection state). This allows ProseMirror to recycle DOM elements effectively. Also wrapped `Decoration.widget` components in a factory function to conform with ProseMirror's recycling APIs. Also fixes formatting in .jules/bolt.md using prettier. Co-authored-by: dezren39 <11225574+dezren39@users.noreply.github.com>
…ashing Replaces the global `decorationGeneration` counter (which forced DOM node recreation on every editor state change) with stable keys based on actual cursor data (client ID, position, opacity, and connection state). This allows ProseMirror to recycle DOM elements effectively. Also wrapped `Decoration.widget` components in a factory function to conform with ProseMirror's recycling APIs. Also fixes formatting in .jules/bolt.md using prettier. Co-authored-by: dezren39 <11225574+dezren39@users.noreply.github.com>
…ashing Replaces the global `decorationGeneration` counter (which forced DOM node recreation on every editor state change) with stable keys based on actual cursor data (client ID, position, opacity, and connection state). This allows ProseMirror to recycle DOM elements effectively. Also wrapped `Decoration.widget` components in a factory function to conform with ProseMirror's recycling APIs. Also fixes formatting in .jules/bolt.md using prettier and `cargo clippy` linting warnings in `pkgs/id`. Co-authored-by: dezren39 <11225574+dezren39@users.noreply.github.com>
💡 What: Refactored
pkgs/id/web/src/cursors.tsto remove the globaldecorationGenerationcounter. Instead, we now derive stable keys forDecoration.widgetandDecoration.inlineusing the underlying cursor state (e.g.,clientID,position/head,opacity, andconnectionState). We also updated the widget elements to be returned from a factory function (() => widgetElement).🎯 Why: Previously, the use of an auto-incrementing random generation for widget keys forced ProseMirror to unmount and remount every single cursor DOM node upon any update or keystroke, completely negating ProseMirror's diffing engine.
📊 Impact: Massively reduces layout thrashing and DOM operations during collaborative editing, reducing CPU spike on keystrokes and improving overall typing responsiveness when multiple cursors are visible.
🔬 Measurement: Verify by recording a performance profile in the browser devtools while typing or while remote cursors move. You should observe significantly fewer forced reflows and DOM mutations within the ProseMirror nodeview.
PR created automatically by Jules for task 7337461212199327037 started by @dezren39