Repository navigation
Conversation
This commit implements the factory function pattern for `Decoration.widget` in the cursor plugin to enable DOM node recycling and prevent severe layout thrashing. It replaces a global incrementing counter that forced full recreation of DOM nodes with deterministic string keys derived from cursor properties (e.g., ID, position, opacity, connectionState). This significantly improves performance during collaborative editing by minimizing expensive DOM layouts on every keystroke. Co-authored-by: dezren39 <11225574+dezren39@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This commit implements the factory function pattern for `Decoration.widget` in the cursor plugin to enable DOM node recycling and prevent severe layout thrashing. It replaces a global incrementing counter that forced full recreation of DOM nodes with deterministic string keys derived from cursor properties (e.g., ID, position, opacity, connectionState). This significantly improves performance during collaborative editing by minimizing expensive DOM layouts on every keystroke. In addition, it fixes a CI pipeline issue caused by a deprecated GitHub Action (`pozil/auto-assign-issue@v1` bumped to `v2`) and resolves a syntax error in a Nix test file that broke `statix check`. Co-authored-by: dezren39 <11225574+dezren39@users.noreply.github.com>
This commit implements the factory function pattern for `Decoration.widget` in the cursor plugin to enable DOM node recycling and prevent severe layout thrashing. It replaces a global incrementing counter that forced full recreation of DOM nodes with deterministic string keys derived from cursor properties (e.g., ID, position, opacity, connectionState). This significantly improves performance during collaborative editing by minimizing expensive DOM layouts on every keystroke. In addition, it fixes a CI pipeline issue caused by a deprecated GitHub Action (`pozil/auto-assign-issue@v1` bumped to `v2`) and resolves a syntax error in a Nix test file that broke `statix check`. Co-authored-by: dezren39 <11225574+dezren39@users.noreply.github.com>
This commit implements the factory function pattern for `Decoration.widget` in the cursor plugin to enable DOM node recycling and prevent severe layout thrashing. It replaces a global incrementing counter that forced full recreation of DOM nodes with deterministic string keys derived from cursor properties (e.g., ID, position, opacity, connectionState). This significantly improves performance during collaborative editing by minimizing expensive DOM layouts on every keystroke. In addition, it fixes a CI pipeline issue caused by a deprecated GitHub Action (`pozil/auto-assign-issue@v1` bumped to `v2`) and resolves a syntax error in a Nix test file that broke `statix check`. It also ensures `nixfmt` works correctly by switching to `nixfmt-rfc-style`. Co-authored-by: dezren39 <11225574+dezren39@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 What: Implements the factory function pattern
() => HTMLElementforDecoration.widgetin the cursor plugin and deriveskeyattributes deterministically from underlying properties rather than a global counter.🎯 Why: ProseMirror reuses DOM nodes for decorations if the
keymatches, avoiding layout thrashing. The previous implementation changed thekeyon every keystroke, forcing full tree recreation and synchronous evaluation before render.📊 Impact: Eliminates expensive DOM layout calculations and repaints on every keystroke, significantly improving editing performance, especially with multiple active collaborative cursors.
🔬 Measurement: Verify editing smoothness in a document with several simulated cursors. The improvement is evident in reduced CPU time spent in layout/paint during tracing.
PR created automatically by Jules for task 15432993329915624448 started by @dezren39