Skip to content
This repository was archived by the owner on Jun 29, 2023. It is now read-only.

✨ Explicitly require process#1976

Merged
kt3k merged 1 commit intodenoland:mainfrom
UltiRequiem:main
Dec 27, 2021
Merged

✨ Explicitly require process#1976
kt3k merged 1 commit intodenoland:mainfrom
UltiRequiem:main

Conversation

@UltiRequiem
Copy link
Copy Markdown
Contributor

No description provided.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Dec 26, 2021

CLA assistant check
All committers have signed the CLA.

@crowlKats
Copy link
Copy Markdown
Member

whats the reasoning for this?

@UltiRequiem
Copy link
Copy Markdown
Contributor Author

whats the reasoning for this?

https://nodejs.org/api/process.html#process

While it is available as a global, it is recommended to explicitly access it via require or import.

Sorry, forgot to put in the description.

@kt3k
Copy link
Copy Markdown
Contributor

kt3k commented Dec 27, 2021

Node.js seems to have started recommending non-global process and Buffer since v16.x nodejs/node#39043

Copy link
Copy Markdown
Contributor

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 21ab9dd into denoland:main Dec 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants