Skip to content

fix: add "module.exports" export to ESM CJS wrapper module#28373

Merged
dsherret merged 1 commit intodenoland:mainfrom
dsherret:fix_add_module_exports_export
Mar 3, 2025
Merged

fix: add "module.exports" export to ESM CJS wrapper module#28373
dsherret merged 1 commit intodenoland:mainfrom
dsherret:fix_add_module_exports_export

Conversation

@dsherret
Copy link
Copy Markdown
Contributor

@dsherret dsherret commented Mar 3, 2025

Part of #28352 (need to ensure require esm uses this after)

Copy link
Copy Markdown
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret
Copy link
Copy Markdown
Contributor Author

dsherret commented Mar 3, 2025

I don't think node is actually doing "module.exports" on import(cjs),

It is. See the linked PR in Node.js.

my issue was just about supporting it for require(esm)

See the PR description: "need to ensure require esm uses this after" (I'll do this after this PR. This does not close that issue)

@dsherret dsherret enabled auto-merge (squash) March 3, 2025 16:13
@dsherret dsherret merged commit a566d8b into denoland:main Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants