Add deepspeed for the glue finetuning tasks & bert-large scripts#77
Merged
Conversation
minjiazhang
reviewed
Jan 12, 2021
Contributor
minjiazhang
left a comment
There was a problem hiding this comment.
Looks good to me overall. Added one minor comment that needs to be addressed.
| action='store_true', | ||
| default=False, | ||
| help= | ||
| "Whether to display the breakdown of the wall-clock time for foraward, backward and step" |
Contributor
There was a problem hiding this comment.
The description appears to be wrong. Perhaps change it "Switching to the variant of Transformer blocks that use pre-LayerNorm."
Contributor
Author
There was a problem hiding this comment.
Of course, thanks Minjia :)
minjiazhang
approved these changes
Jan 14, 2021
Contributor
minjiazhang
left a comment
There was a problem hiding this comment.
LGTM! Thanks for making the changes.
conglongli
approved these changes
Jan 15, 2021
hwchen2017
pushed a commit
that referenced
this pull request
Jun 8, 2025
* Add deepspeed for the glue finetuning tasks & add bert-large scripts and configs * change preln argument description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…and configs