Change DS-Chat script flags for deployment type#291
Merged
Conversation
tjruwase
reviewed
Apr 13, 2023
tjruwase
approved these changes
Apr 13, 2023
hwchen2017
pushed a commit
that referenced
this pull request
Jun 8, 2025
* refactor num-gpus flag to deployment-type * update docs * improve error message --------- Co-authored-by: Zhewei Yao <zheweiy@berkeley.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the deployment type (i.e., single gpu, single node, and multi-node) are controlled by the
--num-gpusflag with the options restricted to 1,8,64. However, this is misleading as the number of GPUs on a user's node may not be 8 and they may not be running on 8 nodes.Resolving this confusion by changing the flag to
deployment-typewith the optionssingle_gpusingle_nodeandmulti_node.resolves #288
Need to merge deepspeedai/DeepSpeed#3219 after this is merged