fix-step3-readme#286
Merged
Merged
Conversation
yaozhewei
reviewed
Apr 13, 2023
| ```bash | ||
| applications/DeepSpeed-Chat/training/utils/model/model_utils.py#L60 | ||
| ``` | ||
| ⚡⚡⚡ When you use above script, please make sure you set `rlhf_training` is False |
Contributor
There was a problem hiding this comment.
Good catch @zhangfanTJU. Could you add more context for other users to understanding where they should set rlhf_training to be false
Contributor
Author
There was a problem hiding this comment.
Thank you very much for your reply and suggestions. I have revised the readme. Additionally, I did not provide a specific line number as the code is constantly being updated.
yaozhewei
approved these changes
Apr 28, 2023
Syulin7
pushed a commit
to Syulin7/DeepSpeedExamples
that referenced
this pull request
May 15, 2023
* fix-step3-readme * Update README.md --------- Co-authored-by: Zhewei Yao <zheweiy@berkeley.edu>
leocnj
pushed a commit
to leocnj/DeepSpeedExamples
that referenced
this pull request
May 27, 2023
* fix-step3-readme * Update README.md --------- Co-authored-by: Zhewei Yao <zheweiy@berkeley.edu>
hwchen2017
pushed a commit
that referenced
this pull request
Jun 8, 2025
* fix-step3-readme * Update README.md --------- Co-authored-by: Zhewei Yao <zheweiy@berkeley.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix readme in step3.