Skip to content

chore: update GET /integrations with includeMetadata - #367

Merged
dinohamzic merged 2 commits into
mainfrom
dinohamzic/get-integrations-endpoint-include-metadata
Apr 30, 2026
Merged

chore: update GET /integrations with includeMetadata#367
dinohamzic merged 2 commits into
mainfrom
dinohamzic/get-integrations-endpoint-include-metadata

Conversation

@dinohamzic

@dinohamzic dinohamzic commented Apr 29, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features
    • Integration requests now automatically include metadata, providing users with more complete information about available integrations.

@dinohamzic dinohamzic self-assigned this Apr 29, 2026
@coderabbitai

coderabbitai Bot commented Apr 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 164dff05-5c8e-4bca-b027-1fcfc714d020

📥 Commits

Reviewing files that changed from the base of the PR and between 3ec2d09 and bf6d719.

📒 Files selected for processing (2)
  • packages/cli/src/integrations/fetch-integrations.test.ts
  • packages/cli/src/integrations/fetch-integrations.ts
📝 Walkthrough

Walkthrough

The fetchIntegrations function now appends the includeMetadata=true query parameter to the /v2/integrations API request. The corresponding test was updated to validate this parameter is included. No changes to error handling, response parsing, or other request logic.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Updates Docs ⚠️ Warning PR implements includeMetadata feature but lacks documentation updates in OSS repository for the GET /integrations endpoint. Update API documentation in deepnote-internal private repository and create OSS repository documentation for the GET /integrations endpoint with parameter details.
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Title clearly describes the main change: adding includeMetadata parameter to the GET /integrations endpoint.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Apr 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.24%. Comparing base (f3bbb6f) to head (b73aa91).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #367   +/-   ##
=======================================
  Coverage   82.23%   82.24%           
=======================================
  Files         144      144           
  Lines        5867     5868    +1     
  Branches     1096     1096           
=======================================
+ Hits         4825     4826    +1     
  Misses       1042     1042

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dinohamzic
dinohamzic marked this pull request as ready for review April 29, 2026 10:09
@dinohamzic
dinohamzic requested a review from a team as a code owner April 29, 2026 10:09
@dinohamzic
dinohamzic requested a review from tkislan April 29, 2026 10:09
@dinohamzic
dinohamzic merged commit 6d60842 into main Apr 30, 2026
19 checks passed
@dinohamzic
dinohamzic deleted the dinohamzic/get-integrations-endpoint-include-metadata branch April 30, 2026 13:22
@tkislan tkislan mentioned this pull request Jun 16, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tkislan tkislan tkislan approved these changes
@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

@dinohamzic dinohamzic

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dinohamzic @tkislan