Skip to content

caching enabled status per logger #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Qix- merged 2 commits into from
Dec 9, 2020
+14 −1
Merged

caching enabled status per logger #799

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0f645e
caching enabled status per logger
containmentbreach Dec 3, 2020
2c6f610
Apply suggestions from code review
containmentbreach Dec 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review 
Co-authored-by: Qix <Qix-@users.noreply.github.com>
  • Loading branch information
@containmentbreach @Qix-
containmentbreach and Qix- authored Dec 9, 2020
commit 2c6f6107ed10c60b52cc133f35ca788c582891aa
7 changes: 4 additions & 3 deletions src/common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ function setup(env) {
function createDebug(namespace) {
let prevTime;
let enableOverride = null;
let namespacesCache, enabledCache;
let namespacesCache;
let enabledCache;

function debug(...args) {
// Disabled?
Expand Down Expand Up @@ -123,14 +124,14 @@ function setup(env) {
configurable: false,
get: () => {
if (enableOverride !== null) {
return enableOverride
return enableOverride;
}
if (namespacesCache !== createDebug.namespaces) {
namespacesCache = createDebug.namespaces;
enabledCache = createDebug.enabled(namespace);
}
return enabledCache;

return enabledCache;
},
set: v => {
enableOverride = v;
Expand Down