Skip to content

Punctuation fixes #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deathsythe47 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Punctuation fixes #148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ them, are:
at the top of the new issue / PR page instead of that link. Maintainers can
choose to inline content there and / or link to other pages as appropriate.

Hopefully none of these are a surprise to you as we’ve told you them before.
Hopefully, none of these are a surprise to you, as we’ve told you them before.
We’ve waited years now for progress on any of them. If GitHub were open source
itself, we would be implementing these things ourselves as a community—we’re
itself, we would be implementing these things ourselves as a community — we’re
Copy link
Copy Markdown

@resurtm resurtm Nov 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not valid. See:
https://en.oxforddictionaries.com/grammar/dash-and-em-dash
https://english.stackexchange.com/questions/214585/space-before-after-emdash-or-not

Copy link
Copy Markdown

@girng girng Mar 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@resurtm to be fair, there is no way communty-we're is correct either

Copy link
Copy Markdown

@aethelwulffe aethelwulffe Jun 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hyphens? Try a semicolon. They were not invented for C syntax. Hyphens are emotively used, but even non-liberal arts majors can learn to use semicolons. 😄

very good at that!

Signed,
Expand Down