Sourcery refactored dev branch by sourcery-ai[bot] · Pull Request #1 · dciborow/azure-devops-python-api

sourcery-ai · 2023-05-11T07:22:48Z

Branch dev refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the dev branch, then run:

git fetch origin sourcery/dev
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

sourcery-ai

Sourcery timed out performing refactorings.

Due to GitHub API limits, only the first 60 comments can be shown.

sourcery-ai · 2023-05-11T07:22:52Z

-            logger.info("Deleting file: " + self.file_name)
+            logger.info(f"Deleting file: {self.file_name}")
            os.remove(self.file_name)
        else:
-            logger.info("File does not exist: " + self.file_name)
+            logger.info(f"File does not exist: {self.file_name}")


Function FileCache.clear refactored with the following changes:

Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

sourcery-ai · 2023-05-11T07:22:52Z


 def get_cache(name, max_age=DEFAULT_MAX_AGE, cache_dir=DEFAULT_CACHE_DIR):
-    file_name = os.path.join(cache_dir, name + '.json')
+    file_name = os.path.join(cache_dir, f'{name}.json')


Function get_cache refactored with the following changes:

Use f-string instead of string concatenation (use-fstring-for-concatenation)

sourcery-ai · 2023-05-11T07:22:52Z

            pass

-    raise ValueError('Failed to decode file {} - unknown decoding'.format(file_path))
+    raise ValueError(f'Failed to decode file {file_path} - unknown decoding')


Function read_file_content refactored with the following changes:

Replace call to format with f-string (use-fstring-for-formatting)

sourcery-ai · 2023-05-11T07:22:52Z

-                or (TRACE_ENV_VAR_COMPAT in os.environ and os.environ[TRACE_ENV_VAR_COMPAT] == 'true'):
-            print(request.method + ' ' + request.url)
+                    or (TRACE_ENV_VAR_COMPAT in os.environ and os.environ[TRACE_ENV_VAR_COMPAT] == 'true'):
+            print(f'{request.method} {request.url}')


Function Client._send_request refactored with the following changes:

Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

sourcery-ai · 2023-05-11T07:22:52Z

-        headers = {'Content-Type': media_type + '; charset=utf-8',
-                   'Accept': accept_media_type + ';api-version=' + negotiated_version}
+        headers = {
+            'Content-Type': f'{media_type}; charset=utf-8',
+            'Accept': f'{accept_media_type};api-version={negotiated_version}',
+        }


Function Client._send refactored with the following changes:

Use f-string instead of string concatenation [×3] (use-fstring-for-concatenation)

sourcery-ai · 2023-05-11T07:22:54Z

-        if "callback" in kwargs:
-            callback = kwargs["callback"]
-        else:
-            callback = None
+        callback = kwargs.get("callback", None)


Function BuildClient.get_file refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

Simplify dictionary access using default get (default-get)

sourcery-ai · 2023-05-11T07:22:54Z

-        if "callback" in kwargs:
-            callback = kwargs["callback"]
-        else:
-            callback = None
+        callback = kwargs.get("callback", None)


Function BuildClient.get_attachment refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

Simplify dictionary access using default get (default-get)

sourcery-ai · 2023-05-11T07:22:54Z

-        if "callback" in kwargs:
-            callback = kwargs["callback"]
-        else:
-            callback = None
+        callback = kwargs.get("callback", None)


Function BuildClient.get_file_contents refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

Simplify dictionary access using default get (default-get)

sourcery-ai · 2023-05-11T07:22:54Z

-        if "callback" in kwargs:
-            callback = kwargs["callback"]
-        else:
-            callback = None
+        callback = kwargs.get("callback", None)


Function BuildClient.get_build_log refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

Simplify dictionary access using default get (default-get)

sourcery-ai · 2023-05-11T07:22:54Z

-        if "callback" in kwargs:
-            callback = kwargs["callback"]
-        else:
-            callback = None
+        callback = kwargs.get("callback", None)


Function BuildClient.get_build_logs_zip refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

Simplify dictionary access using default get (default-get)

sourcery-ai · 2023-05-11T07:22:58Z

-        if "callback" in kwargs:
-            callback = kwargs["callback"]
-        else:
-            callback = None
+        callback = kwargs.get("callback", None)


Function BuildClient.get_build_log_zip refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

Simplify dictionary access using default get (default-get)

sourcery-ai · 2023-05-11T07:22:58Z

-        if "callback" in kwargs:
-            callback = kwargs["callback"]
-        else:
-            callback = None
+        callback = kwargs.get("callback", None)


Function BuildClient.get_build_report_html_content refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

Simplify dictionary access using default get (default-get)

sourcery-ai · 2023-05-11T07:22:58Z

-            callback = kwargs["callback"]
-        else:
-            callback = None
+        callback = kwargs.get("callback", None)


Function FeedClient.get_badge refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

Simplify dictionary access using default get (default-get)

sourcery-ai · 2023-05-11T07:22:58Z

-            callback = kwargs["callback"]
-        else:
-            callback = None
+        callback = kwargs.get("callback", None)


Function GitClientBase.get_blob_content refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

Simplify dictionary access using default get (default-get)

sourcery-ai · 2023-05-11T07:22:59Z

-        if "callback" in kwargs:
-            callback = kwargs["callback"]
-        else:
-            callback = None
+        callback = kwargs.get("callback", None)


Function GitClientBase.get_blobs_zip refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

Simplify dictionary access using default get (default-get)

sourcery-ai · 2023-05-11T07:23:00Z

-        if "callback" in kwargs:
-            callback = kwargs["callback"]
-        else:
-            callback = None
+        callback = kwargs.get("callback", None)


Function NpmClient.get_readme_scoped_package refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

Simplify dictionary access using default get (default-get)

sourcery-ai · 2023-05-11T07:23:00Z

-        if "callback" in kwargs:
-            callback = kwargs["callback"]
-        else:
-            callback = None
+        callback = kwargs.get("callback", None)


Function NpmClient.get_readme_unscoped_package refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

Simplify dictionary access using default get (default-get)

sourcery-ai · 2023-05-11T07:23:00Z

-            callback = kwargs["callback"]
-        else:
-            callback = None
+        callback = kwargs.get("callback", None)


Function ReleaseClient.get_release_task_attachment_content refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

Simplify dictionary access using default get (default-get)

sourcery-ai · 2023-05-11T07:23:01Z

-        if "callback" in kwargs:
-            callback = kwargs["callback"]
-        else:
-            callback = None
+        callback = kwargs.get("callback", None)


Function ReleaseClient.get_logs refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

Simplify dictionary access using default get (default-get)

sourcery-ai · 2023-05-11T07:23:01Z

-        if "callback" in kwargs:
-            callback = kwargs["callback"]
-        else:
-            callback = None
+        callback = kwargs.get("callback", None)


Function ReleaseClient.get_task_log refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

Simplify dictionary access using default get (default-get)

sourcery-ai · 2023-05-11T07:23:05Z

-        if "callback" in kwargs:
-            callback = kwargs["callback"]
-        else:
-            callback = None
+        callback = kwargs.get("callback", None)


Function ReleaseClient.get_release_revision refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

Simplify dictionary access using default get (default-get)

sourcery-ai · 2023-05-11T07:23:05Z

-        if "callback" in kwargs:
-            callback = kwargs["callback"]
-        else:
-            callback = None
+        callback = kwargs.get("callback", None)


Function ReleaseClient.get_definition_revision refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

Simplify dictionary access using default get (default-get)

sourcery-ai · 2023-05-11T07:23:05Z

-            callback = kwargs["callback"]
-        else:
-            callback = None
+        callback = kwargs.get("callback", None)


Function TaskClient.create_attachment refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

Simplify dictionary access using default get (default-get)

sourcery-ai · 2023-05-11T07:23:05Z

-        if "callback" in kwargs:
-            callback = kwargs["callback"]
-        else:
-            callback = None
+        callback = kwargs.get("callback", None)


Function TaskClient.get_attachment_content refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

Simplify dictionary access using default get (default-get)

sourcery-ai · 2023-05-11T07:23:05Z

-        if "callback" in kwargs:
-            callback = kwargs["callback"]
-        else:
-            callback = None
+        callback = kwargs.get("callback", None)


Function TaskClient.append_log_content refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

Simplify dictionary access using default get (default-get)

sourcery-ai · 2023-05-11T07:23:07Z

-        if "callback" in kwargs:
-            callback = kwargs["callback"]
-        else:
-            callback = None
+        callback = kwargs.get("callback", None)


Function TfvcClient.get_item_content refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

Simplify dictionary access using default get (default-get)

sourcery-ai · 2023-05-11T07:23:07Z

-        if "callback" in kwargs:
-            callback = kwargs["callback"]
-        else:
-            callback = None
+        callback = kwargs.get("callback", None)


Function TfvcClient.get_item_text refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

Simplify dictionary access using default get (default-get)

sourcery-ai · 2023-05-11T07:23:07Z

-        if "callback" in kwargs:
-            callback = kwargs["callback"]
-        else:
-            callback = None
+        callback = kwargs.get("callback", None)


Function TfvcClient.get_item_zip refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

Simplify dictionary access using default get (default-get)

sourcery-ai · 2023-05-11T07:23:08Z

-            callback = kwargs["callback"]
-        else:
-            callback = None
+        callback = kwargs.get("callback", None)


Function WikiClient.create_attachment refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

Simplify dictionary access using default get (default-get)

sourcery-ai · 2023-05-11T07:23:08Z

-        if "callback" in kwargs:
-            callback = kwargs["callback"]
-        else:
-            callback = None
+        callback = kwargs.get("callback", None)


Function WikiClient.get_page_text refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

Simplify dictionary access using default get (default-get)

'Refactored by Sourcery'

9bba9bd

sourcery-ai Bot requested a review from dciborow May 11, 2023 07:22

sourcery-ai Bot commented May 11, 2023

View reviewed changes

Conversation

sourcery-ai Bot commented May 11, 2023

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot May 11, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot May 11, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot May 11, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot May 11, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot May 11, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot May 11, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot May 11, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot May 11, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot May 11, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot May 11, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot May 11, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot May 11, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot May 11, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot May 11, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot May 11, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot May 11, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot May 11, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot May 11, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot May 11, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot May 11, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot May 11, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot May 11, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot May 11, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot May 11, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot May 11, 2023

Choose a reason for hiding this comment