Merge pull request apache#1561 from sanju1010/startport

swill · swill · commit ecac28ba4e7e · 2016-05-26T15:53:01.000-04:00
CLOUDSTACK-9388: Remove string conversion in assertion statementRemove string convertion in Assertion statement, since the start port parameter in listFirewallAPI response is of type integer

Test Result:
=========
"Checking firewall rules deletion after static NAT disable ... === TestName: test_01_firewall_rules_port_fw | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 1 test in 153.974s

OK

* pr/1561:
  CLOUDSTACK-9388: Remove string conversion in assertion statement

Signed-off-by: Will Stevens &lt;williamstevens@gmail.com&gt;
diff --git a/test/integration/component/test_blocker_bugs.py b/test/integration/component/test_blocker_bugs.py
@@ -409,7 +409,7 @@ def test_01_firewall_rules_port_fw(self):
                         )
         self.assertEqual(
                             firewall_response[0].startport,
-                            str(self.services["firewall_rule"]["startport"]),
+                            self.services["firewall_rule"]["startport"],
                             "Firewall rule is not with specific port"
                         )
 

Original file line number	Diff line number	Diff line change
`@@ -409,7 +409,7 @@ def test_01_firewall_rules_port_fw(self):`
`409`	`409`	`)`
`410`	`410`	`self.assertEqual(`
`411`	`411`	`firewall_response[0].startport,`
`412`		`- str(self.services["firewall_rule"]["startport"]),`
	`412`	`+ self.services["firewall_rule"]["startport"],`
`413`	`413`	`"Firewall rule is not with specific port"`
`414`	`414`	`)`
`415`	`415`