CLOUDSTACK-9388: Remove string conversion in assertion statement#1561
Merged
Conversation
Contributor
|
Very small change , conversion of firewall port to string was not necessary and that seems to be removed. Looks Good to me !! |
Contributor
|
Simple change. LGTM |
Contributor
|
@sanju1010 thanks for posting the test results with this change. This one should be good now. Thanks everyone... |
asfgit
pushed a commit
that referenced
this pull request
May 26, 2016
CLOUDSTACK-9388: Remove string conversion in assertion statementRemove string convertion in Assertion statement, since the start port parameter in listFirewallAPI response is of type integer Test Result: ========= "Checking firewall rules deletion after static NAT disable ... === TestName: test_01_firewall_rules_port_fw | Status : SUCCESS === ok ---------------------------------------------------------------------- Ran 1 test in 153.974s OK * pr/1561: CLOUDSTACK-9388: Remove string conversion in assertion statement Signed-off-by: Will Stevens <williamstevens@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove string convertion in Assertion statement, since the start port parameter in listFirewallAPI response is of type integer
Test Result:
"Checking firewall rules deletion after static NAT disable ... === TestName: test_01_firewall_rules_port_fw | Status : SUCCESS ===
ok
Ran 1 test in 153.974s
OK