dbeaver/dbeaver#39426 Fix ask about password#40719
Open
IvanGorshechnikov wants to merge 3 commits intodevelfrom
Open
dbeaver/dbeaver#39426 Fix ask about password#40719IvanGorshechnikov wants to merge 3 commits intodevelfrom
IvanGorshechnikov wants to merge 3 commits intodevelfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the incorrect authentication prompt shown for AWS RDS IAM auth by allowing auth models to supply custom credential prompt fields (e.g., access key + secret key) instead of always showing a single “password” field.
Changes:
- Added
DBPAuthPromptField/DBPAuthPromptInfoto represent multi-field credential prompts and results. - Extended
DBPPlatformUI(and Desktop/Console implementations) with a newpromptUserCredentials(..., List<DBPAuthPromptField>, ...)overload. - Updated
BaseAuthDialogto render either the legacy username/password controls or a dynamic list of credential fields, and updatedDataSourceDescriptorto prompt using auth-model-defined properties.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| plugins/org.jkiss.dbeaver.ui.editors.connection/src/org/jkiss/dbeaver/ui/dialogs/BaseAuthDialog.java | Adds support for rendering and collecting custom credential fields in the auth dialog. |
| plugins/org.jkiss.dbeaver.registry/src/org/jkiss/dbeaver/registry/DataSourceDescriptor.java | Adds auth-model-driven prompting for required credential properties and wires it into connection flow. |
| plugins/org.jkiss.dbeaver.model/src/org/jkiss/dbeaver/runtime/ui/DBPPlatformUI.java | Adds a new UI API overload to prompt for multiple credential fields. |
| plugins/org.jkiss.dbeaver.model/src/org/jkiss/dbeaver/runtime/ui/console/ConsoleUserInterface.java | Implements the new overload (non-interactive mode throws). |
| plugins/org.jkiss.dbeaver.model/src/org/jkiss/dbeaver/model/connection/DBPAuthPromptInfo.java | New model class to return prompted field values + save flag. |
| plugins/org.jkiss.dbeaver.model/src/org/jkiss/dbeaver/model/connection/DBPAuthPromptField.java | New model class describing a prompted credential field. |
| plugins/org.jkiss.dbeaver.model/src/org/jkiss/dbeaver/model/access/DBAAuthModelPromptProperties.java | New interface for auth models to declare which properties must be prompted during connect. |
| plugins/org.jkiss.dbeaver.core/src/org/jkiss/dbeaver/core/DesktopUI.java | Implements the new UI overload by opening BaseAuthDialog with custom fields. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #39426