Build a pinned copy of tzdata for use with CI#1470
Open
pganssle wants to merge 3 commits intodateutil:masterfrom
Open
Build a pinned copy of tzdata for use with CI#1470pganssle wants to merge 3 commits intodateutil:masterfrom
pganssle wants to merge 3 commits intodateutil:masterfrom
Conversation
This bypasses SSL validation, which can be a sticking point with old python versions, and the risk here seems very low.
This uses a single job to build the zoneinfo directory for a pinned TZDATA version (cached), which can then be reused in all other jobs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
This allows us to pin to a specific version rather than relying on whatever is on the system version.
This is implemented as a single (cached) job to build the TZif files which are then used by anything that needs them.
Pull Request Checklist