Skip to content
This repository was archived by the owner on Jul 25, 2022. It is now read-only.

Added ParquetReadOptions to register_parquet.#52

Merged
jimexist merged 4 commits into
datafusion-contrib:mainfrom
samkaufman:main
Jun 22, 2022
Merged

Added ParquetReadOptions to register_parquet.#52
jimexist merged 4 commits into
datafusion-contrib:mainfrom
samkaufman:main

Conversation

@samkaufman
Copy link
Copy Markdown
Contributor

@samkaufman samkaufman commented May 29, 2022

This PR adds optional keyword args. to register_parquet which update ParquetReadOptions' defaults.

@samkaufman samkaufman changed the title Added ParquetReadOptions to read_parquet API. Added ParquetReadOptions to register_parquet. May 29, 2022
@samkaufman samkaufman marked this pull request as ready for review May 29, 2022 04:12
@jimexist
Copy link
Copy Markdown
Contributor

hi @samkaufman thanks for your contribution - do you mind adding a unit test?

@samkaufman
Copy link
Copy Markdown
Contributor Author

@jimexist Happy to. How's the one added in 7bab716?

@jimexist
Copy link
Copy Markdown
Contributor

jimexist commented Jun 4, 2022

do you mind fixing the linter err?

@samkaufman
Copy link
Copy Markdown
Contributor Author

@jimexist That should do it.

@jimexist jimexist merged commit 9f926cc into datafusion-contrib:main Jun 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants