Remove API key requirement and rebrand to Python API (not Python Clie… - #131
Conversation
|
Tested in a notebook-- but fixed the date after. |
| """ | ||
| os.environ[_ENV_VAR_API_KEY] = api_key | ||
| """DEPRECATED FUNCTION--API keys no longer required.""" | ||
| logging.warning('Data Commons has removed the API key requirement. This function will be removed by Dec 1st, 2020.') |
There was a problem hiding this comment.
@beets wanted you to review this decision :)
There was a problem hiding this comment.
Lg. Do we have other docs/codes to remove this as well?
There was a problem hiding this comment.
Yeah need to update docsite... I think that's it. I went through the api-python repo pretty carefully to remove api key refs.
There was a problem hiding this comment.
Thanks for calling this out!
I don't think we want to remove this completely. We're allowing you to use it without a key, but if you already have one, we should continue allowing you to set it.
| """ | ||
| os.environ[_ENV_VAR_API_KEY] = api_key | ||
| """DEPRECATED FUNCTION--API keys no longer required.""" | ||
| logging.warning('Data Commons has removed the API key requirement. This function will be removed by Dec 1st, 2020.') |
There was a problem hiding this comment.
Lg. Do we have other docs/codes to remove this as well?
|
Thanks for review! @beets I can submit a patch if you have any other feedback. Will follow up with you tomorrow, before doing PIP release |
…nt API).