[oracle] hide internal configuration fields in sink UI#673
Open
vikasrathee-cs wants to merge 1 commit into
Open
[oracle] hide internal configuration fields in sink UI#673vikasrathee-cs wants to merge 1 commit into
vikasrathee-cs wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds four new hidden configuration properties (treatAsOldTimestamp, treatPrecisionlessNumAsDeci, treatTimestampLTZAsTimestamp, and enableXmlType) to the Oracle batch sink widget configuration. However, these newly added properties are not declared in the corresponding OracleSinkConfig class in OracleSink.java. This omission will cause pipeline deployment and runtime failures due to unknown properties. To resolve this, these fields should be added to the Java configuration class as @Nullable fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[oracle] hide internal configuration fields in sink UI, these were added for DTS use cases.
Fields are treatAsOldTimestamp, treatPrecisionlessNumAsDeci, treatTimestampLTZAsTimestamp and enableXmlType.