Skip to content

docs: clarify input arrays in device placement #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgryte merged 6 commits into from
Jun 23, 2025
+6 −6
Merged

docs: clarify input arrays in device placement #919

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bac887c
Clarify input arrays in device placement
crusaderky Apr 1, 2025
b7e80d3
Revert 2021-2024
crusaderky Apr 18, 2025
b25da1a
rework
crusaderky Apr 18, 2025
0b92258
rework
crusaderky Apr 18, 2025
cf6331b
Merge branch 'main' into device
crusaderky Apr 18, 2025
54816e9
Update spec/draft/design_topics/device_support.rst
crusaderky Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update spec/draft/design_topics/device_support.rst 
Co-authored-by: Lucy Liu <jliu176@gmail.com>
  • Loading branch information
@crusaderky @lucyleeow
crusaderky and lucyleeow authored Apr 23, 2025
commit 54816e9e01408b0f0063da7dce18b0c793d3564a
2 changes: 1 addition & 1 deletion spec/draft/design_topics/device_support.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ rather than hard requirements:
- Respect explicit device assignment (i.e. if the input to the ``device=`` keyword is not ``None``, guarantee that the array is created on the given device, and raise an exception otherwise).
- Preserve device assignment as much as possible (e.g. output arrays from a function are expected to be on the same device as input arrays to the function).
- Raise an exception if an operation involves arrays on different devices (i.e. avoid implicit data transfer between devices).
- When a function accepts a mix of arrays and Python scalars, the scalars should inherit the device of the arrays, much like it happens with :ref:`type-promotion`.
- When a function accepts a mix of arrays and Python scalars, the scalars should inherit the device of the arrays, much like what happens with :ref:`type-promotion`.
- Use a default for ``device=None`` which is consistent between functions within the same library.
- If a library has multiple ways of controlling device placement, the most explicit method should have the highest priority:

Expand Down