Throwing an error when reloaded sources when reloaded_sources.json is empty or null#2810
Merged
Markzipan merged 13 commits intodart-lang:mainfrom Apr 10, 2026
Merged
Throwing an error when reloaded sources when reloaded_sources.json is empty or null#2810Markzipan merged 13 commits intodart-lang:mainfrom
Markzipan merged 13 commits intodart-lang:mainfrom
Conversation
nshahan
reviewed
Apr 2, 2026
nshahan
requested changes
Apr 8, 2026
nshahan
reviewed
Apr 8, 2026
Markzipan
added a commit
that referenced
this pull request
Apr 13, 2026
… empty or null (#2810) This error was being swallowed, making debugging a pain. Also includes a change to set chrome proxy service's canary flag when DDC modules are specified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was causing some webdev tests to error and time out.
Also includes a change to set chrome proxy service's
canaryflag when DDC modules are specified.