Skip to content

Creating experimental flag for web hot reload in webdev and splitting tests between DDC module systems#2807

Merged
Markzipan merged 53 commits intodart-lang:mainfrom
Markzipan:webdev-tests-addendum
Apr 17, 2026
Merged

Creating experimental flag for web hot reload in webdev and splitting tests between DDC module systems#2807
Markzipan merged 53 commits intodart-lang:mainfrom
Markzipan:webdev-tests-addendum

Conversation

@Markzipan
Copy link
Copy Markdown
Contributor

@Markzipan Markzipan commented Mar 31, 2026

Migrates webdev/webdev/test tests to *_amd_test and _ddc_library_bundle_test files.

Adds web-hot-reload experiment to webdev.

Also fixes some build issues related to reloadedSources not being properly resolved (null) when restarting/reloading an app without code changes, causing cascading errors/hangs in the test framework. reloaded_sources.json will also be served with a relative URL (so its host can be automatically resolved).

@Markzipan Markzipan marked this pull request as ready for review April 7, 2026 23:02
@Markzipan Markzipan changed the title Splitting webdev/webdev tests between DDC module systems Creating experimental flag for web hot reload in webdev and splitting tests between DDC module systems Apr 10, 2026
Copy link
Copy Markdown
Contributor

@nshahan nshahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's be careful about not combining too many changes to the tests with behavior as well. What do we need from this change to run the two new versions of the tests?

Comment thread webdev/test/test_utils.dart Outdated
Comment thread webdev/pubspec.yaml Outdated
Comment thread webdev/lib/src/command/configuration.dart
Comment thread webdev/lib/src/command/shared.dart Outdated
Comment thread webdev/lib/src/command/configuration.dart
Comment thread webdev/lib/src/command/configuration.dart Outdated
Comment thread webdev/test/test_utils.dart
Comment thread webdev/test/test_utils.dart
@Markzipan Markzipan requested a review from nshahan April 15, 2026 00:56
Comment thread webdev/test/test_utils.dart
Comment thread webdev/test/test_utils.dart Outdated
@Markzipan Markzipan requested a review from nshahan April 16, 2026 00:42
Comment thread webdev/lib/src/command/configuration.dart Outdated
Comment thread webdev/lib/src/command/configuration.dart Outdated
Comment thread webdev/test/configuration_test.dart Outdated
Comment thread webdev/CHANGELOG.md Outdated
Comment thread webdev/lib/src/command/configuration.dart Outdated
Copy link
Copy Markdown
Contributor

@nshahan nshahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Markzipan Markzipan merged commit 1063eb0 into dart-lang:main Apr 17, 2026
164 of 203 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants