Fix inline Desmos calculator - #15924
Conversation
Control bar was improperly inverted (white on white)
Myshor
left a comment
There was a problem hiding this comment.
Thanks for the PR.
Since apclassroom.collegeboard.org requires an account behind an auth-wall, maintainers cannot verify this fix directly.
Please provide screenshots demonstrating the result:
- Before fix (Dark Reader ON)
- After fix (Dark Reader ON)
- After fix but switched to light scheme in Dark Reader (to make sure there are no contrast regressions)
Please also address the inline comments regarding the CI linter failure and the CSS rule.
| .dcg-calculator-api-container-v1_11 .dcg-container .dcg-expression-top-bar { | ||
| background: linear-gradient(#282a2b, #181a1b); | ||
| } | ||
|
|
There was a problem hiding this comment.
Please remove this trailing empty line. It breaks the configuration parser and causes CI tests to fail.
| mix-blend-mode: normal !important; | ||
| } | ||
| .dcg-calculator-api-container-v1_11 .dcg-container .dcg-expression-top-bar { | ||
| background: linear-gradient(#282a2b, #181a1b); |
There was a problem hiding this comment.
If a custom background override is strictly necessary, note that missing !important might cause specificity issues if styles are loaded dynamically by the host app.
Also, if the issue is strictly caused by improper inversion of inline styles, consider whether adding this selector under IGNORE INLINE STYLE would be a cleaner approach.
Control bar was improperly inverted (white on white)