Merge pull request spotify#54 from honnix/patch-2

hewhomustnotbenamed · web-flow · commit 92a7f4fbfc18 · 2021-03-15T09:55:36.000+01:00
Close response to avoid leaking
diff --git a/src/main/java/com/spotify/github/v3/clients/GithubPage.java b/src/main/java/com/spotify/github/v3/clients/GithubPage.java
@@ -38,6 +38,7 @@
 import java.util.Optional;
 import java.util.concurrent.CompletableFuture;
 import java.util.stream.Stream;
+import okhttp3.ResponseBody;
 
 /**
  * Async page implementation for github resources
@@ -157,13 +158,15 @@ private CompletableFuture<Map<String, Link>> linkMapAsync() {
     return github
         .request(path)
         .thenApply(
-            response ->
-                Optional.ofNullable(response.headers().get("Link"))
+            response -> {
+                Optional.ofNullable(response.body()).ifPresent(ResponseBody::close);
+                return Optional.ofNullable(response.headers().get("Link"))
                     .map(linkHeader -> stream(linkHeader.split(",")))
                     .orElseGet(Stream::empty)
                     .map(linkString -> Link.from(linkString.split(";")))
                     .filter(link -> link.rel().isPresent())
-                    .collect(toMap(link -> link.rel().get(), identity())));
+                    .collect(toMap(link -> link.rel().get(), identity()));
+            });
   }
 
   private Optional<Integer> pageNumberFromUri(final String uri) {
