Skip to content

Some fixes - #53

Merged
marco44 merged 2 commits into
dalibo:masterfrom
rjuju:some_fixes
Dec 6, 2016
Merged

Some fixes#53
marco44 merged 2 commits into
dalibo:masterfrom
rjuju:some_fixes

Conversation

@rjuju

@rjuju rjuju commented Dec 6, 2016

Copy link
Copy Markdown
Contributor

PFA a PR with 2 commits:

  • first one fix trivial issue in conf_file parsing (noticed while using the provided example file)
  • second one fix substitution issue I saw with a real dump today. FTR, here's a test case to reproduce it:
ALTER TABLE [dbo].[foo]  WITH CHECK ADD  CONSTRAINT [CHECK_BAR] CHECK  (([DT_START]>[DT_BEGIN]))

was giving:

ALTER TABLE "foo" ADD CONSTRAINT "CHECK_BAR" CHECK (DT_START]>[DT_BEGIN);

now gives:

ALTER TABLE "foo" ADD CONSTRAINT "CHECK_BAR" CHECK (DT_START>DT_BEGIN);

@marco44
marco44 merged commit 1d3b4e8 into dalibo:master Dec 6, 2016
@marco44

marco44 commented Dec 6, 2016

Copy link
Copy Markdown
Contributor

I feel a bit ashamed of the first one :)

@rjuju

rjuju commented Dec 6, 2016

Copy link
Copy Markdown
Contributor Author

:)

Thanks for the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants