Skip to content

permit max in typequal in CREATE TYPE #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
madtibo merged 2 commits into from
Mar 24, 2021
Merged

permit max in typequal in CREATE TYPE #145

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c24cc16
permit max in typequal in CREATE TYPE
madtibo Mar 19, 2021
d3700ba
check $typequal definition before comparison
madtibo Mar 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions sqlserver2pgsql.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1824,14 +1824,18 @@ sub parse_dump
my $newtype;
TYPE: while (my $typeline= read_and_clean($file))
{
if ($typeline =~ /^\t\[(.*)\] \[(.*)\](?:\s*?\((\d+(?:,\d+)?)\))?(?:\s+?(?:NOT\s+?)?NULL),?$/)
if ($typeline =~ /^\t\[(.*)\] \[(.+?)\](?:\s*?\((\d+|max(?:,\d+)?)\))?(?:\s+?(?:NOT\s+?)?NULL),?$/)
{
# This is another column for this type
$colname=$1;
$type=$2;
$typequal=$3;
if (defined $typequal and $typequal eq 'max') {
# max in SqlServer is the same as no typequal in pg
$typequal = undef;
}
$newtype =
convert_type($type, $typequal, undef, undef, undef, undef);
convert_type($type, $typequal, undef, undef, undef, undef);
push @cols_newbasetype,(format_identifier($colname) . ' ' . $newtype);
}
elsif ( $typeline =~ /PRIMARY KEY/)
Expand Down