Support IDENTITY with negative arguments - #114
Closed
potrusil-osi wants to merge 2 commits into
Closed
Conversation
potrusil-osi
commented
Sep 26, 2019
Contributor
- Support IDENTITY with negative arguments
- Detect the end of table more generically
Contributor
|
Hello @potrusil-osi Thank you very much for your PR! I have a few questions about it. I will use the comments for them. In order to auto test your PR, do you think you could update one of the sql file in the regression directory? Cordialement, |
Contributor
Author
|
Hi @madtibo, I just added a new testing file to the PR that should cover all my changes. |
Contributor
|
Thank you for the PR. I rebased it to resolve conflicts in #149, so I will close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.