chore: bump polyfill to pick up local dir dep includes - #8
Merged
Conversation
Bump the sdk-sdk polyfill pin to current main (a164663), picking up fix(polyfill): include local dir deps declared in dagger-module.toml (dagger/sdk-sdk#10). Without it, generating a module that depends on a sibling local module fails: the polyfill built the module-source directory without the dep's subtree, so Directory.asModuleSource could not resolve the dependency ("dir module source does not contain a dagger config file"). Signed-off-by: Yves Brissaud <yves@dagger.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump the sdk-sdk polyfill pin
90ecbe4→a164663(current sdk-sdk main), picking up dagger/sdk-sdk#10: fix(polyfill): include local dir deps declared in dagger-module.toml.Why
Generating a module that depends on a sibling local module fails with the pinned polyfill:
The old polyfill builds the module-source directory with an include list covering only the module's own subtree, so
Directory.asModuleSourcecannot resolve the../heydependency. sdk-sdk#10 walks local deps declared indagger-module.tomland includes their subtrees.Verified against the repro with this bump:
dagger generatesucceeds, the generatedgen.pycontains the dependency bindings, and the module loads and is callable.Surfaced by @TomChv while reviewing dagger/dagger#13593 (dagger/dagger#13593 (comment)) — unrelated to that PR's changes, just the stale pin.