Draft
Conversation
Contributor
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Thanks to the Workspace API, modules can discover dynamic sets of related objects (tests by name, packages by path, services by label). But they can't present them to clients without losing features like
check,generate, keyed selection, and batching.Collections fix this. Annotate a module type with
@collection/+collection, and the engine projects it into a public type with standard operations:keys,list,get,subset, andbatch.Design doc covers the problem, proposal, interfaces, and edge cases in detail.
What it looks like
The engine projects this into:
CLI tools understand collections natively:
What's included
checkandgenerate, canonical get IDsdagger checkanddagger generateaccept collection key filtersBundled fix
withExeccache keys now include the call ID (dc87b2cf). Without this, collection items sharing the same exec could incorrectly share cache entries.