fix(elixir-sdk-dev): fix generate function in elixir-sdk#12890
Merged
wingyplus merged 1 commit intodagger:mainfrom Apr 16, 2026
Merged
fix(elixir-sdk-dev): fix generate function in elixir-sdk#12890wingyplus merged 1 commit intodagger:mainfrom
wingyplus merged 1 commit intodagger:mainfrom
Conversation
wingyplus
commented
Mar 31, 2026
| }, | ||
| "dependencies": [ | ||
| { | ||
| "name": "codegen", |
Contributor
Author
There was a problem hiding this comment.
I dont know why it is added but it didnt use in the module so I removing it.
9813235 to
1536ace
Compare
1536ace to
012b8eb
Compare
73294c8 to
c2fedf0
Compare
Contributor
Author
|
Do I need to add a changelog? |
- Change the function name `generate` to `clientLibrary`. - Fix `clientLibrary` function to use introspection json from `daggerEngine` instead of using from the input. - Remove `codegen` dependency. - Make `dagger generate elixir-sdk` works. - Generate the SDK to `sdk/elixir`. Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
c2fedf0 to
0e22d71
Compare
TomChv
approved these changes
Apr 13, 2026
Member
TomChv
left a comment
There was a problem hiding this comment.
No lockfile needed, I tested locally and it worked!
Approved
Contributor
Author
|
Thanks. I will merge it then. 🙏 |
eunomie
added a commit
to sipsma/dagger
that referenced
this pull request
Apr 16, 2026
* upstream/main: Revert "fix: builtin dang dependency module loading (dagger#12975)" (dagger#12994) fix(elixir-sdk-dev): fix generate function in elixir-sdk (dagger#12890) fix: builtin dang dependency module loading (dagger#12975) skills: restore engine playground testing skill (dagger#12929) modules: use built-in dang SDK where safe (dagger#12941) chore: prep for v0.20.6 (dagger#12990) Signed-off-by: Yves Brissaud <yves@dagger.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generatetoclientLibrary.clientLibraryfunction to use introspection json fromdaggerEngineinstead of using from the input.codegendependency.dagger generate elixir-sdkworks.sdk/elixir.